Bug 3 - find-work: finding orphaned outdated packages using pgo command fails
Summary: find-work: finding orphaned outdated packages using pgo command fails
Status: RESOLVED FIXED
Alias: None
Product: Software
Classification: Unclassified
Component: find-work (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- normal
Assignee: Anna (cybertailor) Vyalkova
URL:
Depends on:
Blocks:
 
Reported: 2024-04-23 13:59 UTC by David Roman
Modified: 2024-04-23 15:25 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Roman 2024-04-23 13:59:17 UTC 
When running `find-work -O -I pgo outdated` with a strange error: NotImplementedError: -m option is not implemented for this command

I suppose that it's the orphaned option the one that is not implemented, but the error message is confusing at first.

Full traceback for the error:

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.11/find-work", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/click/decorators.py", line 45, in new_func
    return f(get_current_context().obj, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/find_work/cli/pgo.py", line 173, in outdated
    asyncio.run(_outdated(options))
  File "/usr/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/base_events.py", line 654, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/find_work/cli/pgo.py", line 60, in _outdated
    raise NotImplementedError("-m option is not implemented for this command")
NotImplementedError: -m option is not implemented for this command
Comment 1 Anna (cybertailor) Vyalkova 2024-04-23 14:07:15 UTC 
"--orphaned" flag resolves to "--maintainer=maintainer-needed@gentoo.org" in the default config file (data/default_config.toml).

Would "Filtering by maintainer is not implemented for this command" be better error text?
Comment 2 David Roman 2024-04-23 14:16:09 UTC 
Yep. That would clarify that it's an expected output for the given options, instead of a crash or a bug in the program.